add more validators for attributes and menus and tweak configuration … #66
Conversation
| <xs:element name="oql" type="xs:string" minOccurs="0" /> | ||
| <xs:element name="do_search" type="xs:string" minOccurs="0" /> | ||
| <xs:element name="search_form_open" type="xs:string" minOccurs="0" /> | ||
| <xs:element name="do_search" type="zeroOrOneEnumeration" minOccurs="0" /> |
There was a problem hiding this comment.
Combodo always uses 1 or an empty value for do_search, I did as well.
Should we allow empty values or do we want to restrict this even against use case of Combodo itself?
They only check if it contains 1 or not: https://github.com/Combodo/iTop/blob/8580cb70a41c0b7be36a6b40a993bc3bcf5276fa/setup/compiler.class.inc.php#L2856
There was a problem hiding this comment.
The configuration that combodo does is sometimes very strange. It does not look like it is following some design guides. Sometimes they use true or false, or not present, sometimes they use 1 or anything else, sometimes it is completely different again. I also found occurences of elements that allow a bunch of entries that do all the same - even with some kind of typos in it.
I also thought about this specific element. My idea was to "raise awareness" if there is someting like "true" or "false" (because it would be obvious). but as true would be wrong, I would like to have this as an error in the validation.
At the moment I do not see any other usecase as having the element to be 1 or simply not present, not even empty.
And as having 0 or empty or not present or anything else (not 1) does nothing, it will not hurt.
There was a problem hiding this comment.
Thanks for the reply, will need to update my data models then 😉
…of menus