Skip to content

Conversation

@rudrankriyam
Copy link
Owner

Summary

  • add typed resource/asset enums with pointer optional fields for build upload/submission models
  • extend build upload/submission outputs to table/markdown printers
  • expand client/command tests for JSON structure, validation, and API error paths

Test plan

  • go test ./...

Introduce typed resource/asset enums, pointer optional fields, and table/markdown rendering for upload/submission results. Expand client and command tests while cleaning up stray artifacts.
@cursor
Copy link

cursor bot commented Jan 20, 2026

PR Summary

Adds typed models and end-to-end support for preparing uploads and submitting versions.

  • Types/Enums: Introduce ResourceType, Platform, AssetType, UTI, Checksum* and use typed Resource/relationships with pointer optional fields
  • Client: Implement build upload APIs (CreateBuildUpload, GetBuildUpload, CreateBuildUploadFile, UpdateBuildUploadFile) and App Store submission APIs (CreateAppStoreVersionSubmission, GetAppStoreVersionSubmission, DeleteAppStoreVersionSubmission); adjust GetBuilds to use /v1/builds with filter[app] when sorting/limiting
  • CLI: Add asc builds upload and asc submit; restructure asc builds to parent with list/info/expire/upload; validate flags and print BuildUploadResult/AppStoreVersionSubmissionResult
  • Output: Add table/markdown printers for upload/submission results
  • Tests: Expand client/HTTP/output/command tests for JSON structure, validation errors, and API error paths
  • Docs: Add Go standards and tips in Agents.md; minor config permission constants updated

Written by Cursor Bugbot for commit fb5c5bb. This will update automatically on new commits. Configure here.

Ensure the upload validation test ignores ASC_APP_ID env and align config permission literals with gofumpt formatting.
@rudrankriyam rudrankriyam merged commit 25dbd06 into main Jan 20, 2026
4 checks passed
@rudrankriyam rudrankriyam deleted the feature/build-upload-submit-plan branch January 20, 2026 17:50
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

expire Expire a build for TestFlight`,
asc builds list --app "123456789"
asc builds list --app "123456789" --json
asc builds list --app "123456789" --limit 10 --json`,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate subcommands in BuildsListCommand after refactoring

Medium Severity

BuildsListCommand incorrectly defines Subcommands containing BuildsInfoCommand() and BuildsExpireCommand(), even though these are already registered as sibling subcommands under the parent BuildsCommand. This refactoring error causes duplicate command definitions and creates an unintended command path (asc builds list info) that shouldn't exist. The list command is a leaf command for listing builds and should have no subcommands.

Additional Locations (1)

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants