fix ChildContainer.depth_list child removal when child's depth changed#10405
Open
emgfc wants to merge 2 commits intoruffle-rs:masterfrom
Open
fix ChildContainer.depth_list child removal when child's depth changed#10405emgfc wants to merge 2 commits intoruffle-rs:masterfrom
emgfc wants to merge 2 commits intoruffle-rs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up on #10362
I don't think this should actually be merged as is, just wanted to describe somewhere what's going on.
Ruffle has some sort of a leak in delayed DisplayObject child removing. When a child removing is delayed, that child object (and all of its children recursively) is assigned a negative depth and queued for removing in
ChildContainer::queue_removal()func. Though there's a logic for updating that child element's position in depth_list (removing old ones, inserting new ones), it's not recursive, so nested children objects are having negative depths while being stored in depth_list with their previous positive depths as a keys. And this is the reason why we have lookup errors with that depth_list a bit later.An easy and obvious fix for that would be implementing a recursive
ChildContainer::remove_child_from_depth_list()andChildContainer::insert_child_into_depth_list(). And yes, I did it, and everything just became worse when playing that slimy yellow sponge game.I believe someone smarter than me could actually fix it the right way.