Skip to content

misc: Add devcontainer config #18859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

misc: Add devcontainer config #18859

wants to merge 2 commits into from

Conversation

torokati44
Copy link
Member

This was done on a smartphone using GitHub Copilot.
So that I can do Rust stuff on a smartphone using GitHub Codespaces.
Judge accordingly.

@torokati44 torokati44 added A-other Area: Not covered by other area labels T-chore Type: Chore (like updating a dependency, it's gotta be done) labels Dec 4, 2024
@torokati44
Copy link
Member Author

torokati44 commented Dec 4, 2024 •
edited
Loading

I guess doing this instead would be better...?
https://github.com/devcontainers/features/tree/main/src/rust

@torokati44
Copy link
Member Author

Can confirm, this looks neater, and does add cargo to the tools in the created Codespace.
torokati44@e42d50b

@torokati44 torokati44 marked this pull request as draft December 4, 2024 19:59
@torokati44 torokati44 force-pushed the add-devcontainer branch 2 times, most recently from f05df03 to b2007ae Compare January 17, 2025 18:11
@torokati44 torokati44 marked this pull request as ready for review January 17, 2025 18:11
@torokati44 torokati44 added the waiting-on-review Waiting on review from a Ruffle team member label Jan 17, 2025
@torokati44
Copy link
Member Author

torokati44 commented Apr 14, 2025 •
edited
Loading

TODO: Also enable Dependabot to update this. And maybe add a lockfile? 🤔
EDIT: Former done, latter maybe later. For now, added full versions (not just single-digit major ones) for all components. That's not an upper limit tho...

@torokati44 torokati44 marked this pull request as draft April 14, 2025 14:53
@torokati44 torokati44 removed the waiting-on-review Waiting on review from a Ruffle team member label Apr 14, 2025
@torokati44 torokati44 marked this pull request as ready for review April 15, 2025 11:47
@torokati44
Copy link
Member Author

See: https://containers.dev/overview

@torokati44 torokati44 added the waiting-on-review Waiting on review from a Ruffle team member label Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-other Area: Not covered by other area labels T-chore Type: Chore (like updating a dependency, it's gotta be done) waiting-on-review Waiting on review from a Ruffle team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@torokati44