text: Fix getCharBoundaries() for 0-width characters
#18860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
added
text
adrian17
approved these changes
Dec 9, 2024
core/src/font.rs
Outdated
| x += twips_advance; | ||
| } else { | ||
| // No glyph, zero advance | ||
| glyph_func(pos, &transform, &Glyph::empty(), Twips::ZERO, x); |
Collaborator
There was a problem hiding this comment.
What's the difference between processing a "noop" glyph and skipping it entirely?
Member
Author
There was a problem hiding this comment.
I've described it in my commit message:
This is a natural assumption of Font::evaluate and makes writing code easier.
Code that renders glyphs will work the same way as non-renderable characters
will produce empty glyphs, but code that evaluates the font for measurement
purposes will use this property.
I'll add a short comment about it here too.
kjarosh
force-pushed
the
evaluate-missing-glyphs
branch
2 times, most recently
from
ff00d12 to
d8404e7
Compare
kjarosh
force-pushed
the
evaluate-missing-glyphs
branch
from
d8404e7 to
89c2faa
Compare
kjarosh
force-pushed
the
evaluate-missing-glyphs
branch
from
89c2faa to
8e6d363
Compare
adrian17
approved these changes
Jan 4, 2025
This is a natural assumption of Font::evaluate and makes writing code easier. Code that renders glyphs will work the same way as non-renderable characters will produce empty glyphs, but code that evaluates the font for measurement purposes will use this property.
This test verifies how getCharBoundaries() works when glyphs are missing.
This test verifies how getCharBoundaries() works when glyphs are missing due to embedded font not being present.
kjarosh
force-pushed
the
evaluate-missing-glyphs
branch
from
8e6d363 to
f579bc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically,
getCharBoundaries()returns null for 0-width characters. This PR also fixes a bug where some characters (with missing glyphs) were not taken into account properly becauseFont::evaluateskipped them.