-
-
Notifications
You must be signed in to change notification settings - Fork 881
chore: Reduce binary sizes in desktop releases #19727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Don't we need them for stack traces in crash reports? |
While on web, I can sort of see the point of trying to stay smaller, but on Desktop, and honestly, even in the browser extension, or on mobile, it should basically bear no weight IMHO, at least until we are not in the multi-hundred-MB territory (looks at electron apps). |
If someone wants small: https://upx.github.io/ |
We also explicitly disabled stripping in wasm-opt to preserve symbols:
|
I believe setting
I made this PR was to test whether web works with symbols stripped, because I kinda suspected it will break wasm bindgen (which apparently is true). According to my understanding we have no reason to have symbols on desktop release. |
Stripping symbols and enabling LTO makes the compiled artifacts smaller.
This reduces binary sizes in desktop releases.
Stripping symbols and enabling LTO makes the compiled artifacts smaller.
Desktop Linux shrinks from 40.4MB to 30.6MB.