-
-
Notifications
You must be signed in to change notification settings - Fork 864
core: Run scripts registered at frame script phase in a seperate pass #19941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
0bc3cd9
to
f9970b0
Compare
b0aad6b
to
66c73d2
Compare
additional tests, attached here: |
0856d51
to
0d29a9f
Compare
this test previous tests shown that scripts introduced during cleanup are not executed during traversal, when there were no scripts before. so next guess is that scripts registered during frame-script phase are enqueued for execution separately. |
is there a scenario where the my current_plan is to replace it with EDIT: never mind. will keep |
589f040
to
3150253
Compare
3150253
to
3ae6650
Compare
fixed the behavior for the new test cases. separated there are 2 cases of frame script behavior that i haven't resolved. since both are sufficiently different from the issue addressed by this PR, i will leave them for another time. |
3ae6650
to
fa3b9a6
Compare
fa3b9a6
to
506fcda
Compare
#12942 might be fixed by this. |
fixes #10443, and fixes #14629 for the version that does not include buttons.
when buttons are added to the dynamically constructed object, that is a separate issue of the frame script of the child happening before the parent's constructor finishes
im not sure i nailed down all the subtleties regarding the interaction between the cleanup pass and goto,
but the PR passes all the current tests on my machine, and the tests i made,
so i believe it is ready for review as is.