Skip to content

avm2: Speed up some native calls #20328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 49 commits into
base: master
Choose a base branch
from
Draft

avm2: Speed up some native calls #20328

wants to merge 49 commits into from

Conversation

Lord-McSweeney
Copy link
Collaborator

@Lord-McSweeney Lord-McSweeney commented May 2, 2025 •
edited
Loading

Depends on #20257

This allows us to optimize some calls to native functions when

  1. the function has a [Ruffle(FastCall)] annotation,
  2. the arguments are of the correct count and type, and
  3. the class of the value the function is being called on is final.

For example, Math.abs runs more than twice as fast with this PR as it does on current master. From my testing, in most SWFs, 5-20% of calls that would be CallMethod are now CallNative.

TODO:

  • Record box2d optimization stats
  • Add documentation on FastCall to the globals README
  • Use a HashSet for the FastCall methods...?

Lord-McSweeney added 30 commits May 1, 2025 18:53
avm2: Make getter functions fields for URLLoader
c70cb8e
avm2: Make fields getter/setter functions for MouseEvent
fc0e585
avm2: Minor fixes in VideoTextureEvent, Video, and Telemetry classes
1fb6f57
avm2: Make fields getter/setter functions for Gradient*Filter
87cd082
avm2: Make fields getter/setter functions for DRMReturnVoucher*Event
6286868
avm2: Make text field into an accessor for TextEvent
c84e0d9
avm2: Remove incorrect overrides of getter functions in TextLine
4407f6a
avm2: Use correct method signatures for Microphone
9a77685
avm2: Make x and y fields getter/setter pairs for Stage3D
c62d6c4
avm2: Make Mutex.isSupported a getter
984364f
avm2: Make fields getter/setter functions for GraphicsGradientFill
60750c5
avm2: Make describeType(QName) match FP's output
575bd85
avm2: Make fields getter/setter for SampleDataEvent
8c02717
avm2: Make describeType output for URLVariables and AVPauseAtPeriodEn…
236f518 
…dEvent match FP
avm2: Make activating field a getter/setter for ActivityEvent
c01a486
avm2: Make describeType output for UncaughtErrorEvent and VideoStream…
34b7390 
…Settings match FP
avm2: Make fields getter/setter functions for DRMAuthenticationComple…
4e10ab1 
…teEvent
avm2: Make info field an accessor for NetStatusEvent
da33263
chore: Format AS3 filter classes
06cd77a
avm2: Make enableErrorChecking a field for Context3D
84a971d
avm2: Fix versioning and use accessors for NativeMenuItem properties
4734a4d
avm2: Make fields getter/setter functions for ContextMenuItem
b4615e6
avm2: Make fields getter/setter functions for AVHTTPStatusEvent
ec7eb52
avm2: Make changeList field a getter/setter for SyncEvent
a0b49e9
avm2: Make fields getter/setter functions for StatusEvent
dbf9458
avm2: Make fields getter/setter functions for ProgressEvent
02b76d8
avm2: Make serverURL field an accessor for DRMLicenseRequestEvent
c4ccb62
avm2: Use accessors instead of fields for HTTPStatusEvent
6954215
avm2: Make culling field an accessor for GraphicsTrianglePath
58dd4a6
avm2: Make relatedObject field an accessor for SoftKeyboardEvent
e7a710a
Lord-McSweeney added 19 commits May 1, 2025 18:53
avm2: Use accessors instead of fields for FocusEvent properties
d58fb11
avm2: Use accessors instead of fields for NetConnection properties
eedf4ee
avm2: Use accessors instead of fields for AccelerometerEvent properties
040975c
avm2: Use accessors instead of fields for GestureEvent properties
b2f45ec
avm2: Use accessors instead of fields for DRMAuthenticationErrorEvent…
1f3ddf6 
… properties
avm2: Use accessors instead of fields for TouchEvent properties
71999d8
chore: Format TouchEvent.as
5247ced
avm2: Coerce return value of native methods
89d7cec
avm2: Fix incorrect method return values/types for some native methods
0a92420 
- `Vector$object`'s `push` and `shift` should return `*`, not `Object`
- `DisplayObjectContainer`'s `setChildIndex` returns `void`
avm2: Fully validate all classes using user-provided traits
bd7795a
avm2: Verify that overrides of methods have the same return type
0920564
avm2: Return type of Transform.matrix3D should be *, not void
368287e
avm2: Use type information from return type of getters and methods in…
7e8b458 
… optimizer
avm2: Add ability to mark native methods as "FastCall"
d0d6727
avm2: Actually implement FastCall optimization
c616727 
GetProperty and CallProperty optimization logic have been moved to their own methods
avm2: Assume that arguments exist and are coerced in Math methods
0a21605
avm2: Apply FastCall optimization to most Math methods
9c1ca65
avm2: Add FastCall to more native methods
8a220ed 
Added to methods on Class, Function, Namespace, QName, String, Vector, XML
and XMLList, Graphics, SoundTransform, as well as some toplevel functions and
`getTimer`.
avm2: Make DomainObject::from_domain infallible
331d20c
@Lord-McSweeney Lord-McSweeney added A-avm2 Area: AVM2 (ActionScript 3) T-perf Type: Performance Improvements labels May 2, 2025
@moulins
Copy link
Contributor

moulins commented May 2, 2025 •
edited
Loading

Use a HashSet for the FastCall methods...?

An alternative (maybe simpler to implement?) could be to sort the static array, and use binary_search for O(log n) lookups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-avm2 Area: AVM2 (ActionScript 3) newsworthy T-perf Type: Performance Improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lord-McSweeney @moulins @n0samu