Skip to content

chore: Reformat ActionScript code #20380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kjarosh
Copy link
Member

@kjarosh kjarosh commented May 9, 2025

Reformat AS code: fix .editorconfig violations, remove Adobe documentation, fix obvious formatting mistakes.

Note that this doesn't supersede (or semantically conflict with) #18439. It does fix some formatting mistakes too, but it focuses on fixing .editorconfig violations and removing Adobe documentation.

@kjarosh kjarosh added A-other Area: Not covered by other area labels T-chore Type: Chore (like updating a dependency, it's gotta be done) waiting-on-review Waiting on review from a Ruffle team member labels May 9, 2025
@evilpie
Copy link
Collaborator

evilpie commented May 11, 2025

Should we really be removing the top comment from the autogenerated files?

@kjarosh
Copy link
Member Author

kjarosh commented May 11, 2025

Should we really be removing the top comment from the autogenerated files?

I'm not sure if they have any value. The files were originally generated, but it makes no difference on how we operate on them today. Those comments were more adequate as a commit message in my opinion.

@danielhjacobs
Copy link
Contributor

danielhjacobs commented May 12, 2025

If we remove the comments, we may want to, just for politeness, keep some sort of acknowledgment of https://github.com/golfinq/ActionScript_Event_Builder somewhere, just to at least credit golfinq for the work.

kjarosh added 2 commits May 16, 2025 21:56
Reformat AS code: fix .editorconfig violations, remove Adobe
documentation, fix obvious formatting mistakes.
@kjarosh
Copy link
Member Author

kjarosh commented May 16, 2025

If we remove the comments, we may want to, just for politeness, keep some sort of acknowledgment of https://github.com/golfinq/ActionScript_Event_Builder somewhere, just to at least credit golfinq for the work.

Note that the tool is acknowledged in the git history, additionally I've added a section to the AS3's README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-other Area: Not covered by other area labels T-chore Type: Chore (like updating a dependency, it's gotta be done) waiting-on-review Waiting on review from a Ruffle team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants