core: Introduce BoundsMode enum #22755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

AllinolCP wants to merge 12 commits into ruffle-rs:master from AllinolCP:3611_reimplementation

Contributor

AllinolCP commented Jan 13, 2026

Based on #3611.

Fixes #1915.

Input test made from #3214 (comment)

AllinolCP marked this pull request as draft

January 13, 2026 09:13

AllinolCP force-pushed the 3611_reimplementation branch 5 times, most recently from f58af68 to 2fd64f0 Compare

January 13, 2026 10:27

AllinolCP marked this pull request as ready for review

January 13, 2026 10:45

kjarosh added T-compat squash-on-merge A-core labels

Lord-McSweeney reviewed

View reviewed changes

core/src/display_object.rs Outdated Show resolved Hide resolved

Lord-McSweeney reviewed

View reviewed changes

core/src/display_object.rs Outdated Show resolved Hide resolved

Lord-McSweeney reviewed

View reviewed changes

core/src/display_object/morph_shape.rs Outdated Show resolved Hide resolved

Lord-McSweeney reviewed

View reviewed changes

core/src/display_object/morph_shape.rs Outdated Show resolved Hide resolved

Lord-McSweeney reviewed

View reviewed changes

core/src/prelude.rs Outdated Show resolved Hide resolved

SuchAFuriousDeath suggested changes

View reviewed changes

core/src/display_object/morph_shape.rs Outdated Show resolved Hide resolved

Contributor Author

AllinolCP commented Jan 16, 2026

Sorry for the gazillion commits, I figured since it's going to be squished anyways

AllinolCP requested review from Lord-McSweeney and SuchAFuriousDeath

January 16, 2026 13:34

SuchAFuriousDeath approved these changes

View reviewed changes

core/src/display_object.rs Outdated Show resolved Hide resolved

SuchAFuriousDeath approved these changes

View reviewed changes

Collaborator

SuchAFuriousDeath left a comment

LGTM

nitram779 commented Jan 19, 2026 •

edited

Loading

Tested. It fixes the issue perfectly.

nitram779 mentioned this pull request

Level 38 of Astro Barrier (Club Penguin) is impossible #1915

Open

adrian17 reviewed

View reviewed changes

core/src/display_object.rs Outdated Show resolved Hide resolved

Collaborator

adrian17 commented Jan 19, 2026

OK, so the summary is, the places like these:

as2 MovieClip::getBounds()
as2 Transform::pixelBounds
as3 DO::getBounds()

core DO::pixel_bounds() // used by AS getPixelBounds()
core EditText::pixel_bounds()
core DO::set_width()
core DO::set_height()
core DO::hit_test_object()

should ignore MorphShape's current ratio?

Could this be summarized in one place in code somewhere?
Also, does the test cover the pixel bounds and setters?

AllinolCP requested a review from adrian17

January 24, 2026 15:04

AllinolCP and others added 4 commits

January 27, 2026 11:43


          core: reimplement PR ruffle-rs#3611, as well as add check where hit_t…

ade1aae

…est is called from

Co-Authored-By: relrelb <[email protected]>


          tests: add tests for hittest for morph shape

f274d6d


          chore: fmt

9c91cfa


          core undo HitTestOptions changes

6ccfff4

AllinolCP added 8 commits

January 27, 2026 11:43


          docs: fix incorrect documentation

9490fd2


          address reviews

d669e54

fmt

5075e38


          resolve test coverage issue

c3d5864


          correct documentation again

fff5705


          address review suggestion

c520fe3


          put copy, clone back

753976d


          address reviews and comments from adrian

1943d57

AllinolCP force-pushed the 3611_reimplementation branch from 128df11 to 1943d57 Compare

January 27, 2026 04:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-core squash-on-merge T-compat