avm2: Implement flash.display3D.setProgramConstantsFromByteArray #22775
+2,928
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuchAFuriousDeath
force-pushed
the
stage3d-set-program-constants-from-byte-array
branch
from
40ebeaa to
32654d6
Compare
Lord-McSweeney
added
A-avm2
SuchAFuriousDeath
force-pushed
the
stage3d-set-program-constants-from-byte-array
branch
from
32654d6 to
643aa97
Compare
SuchAFuriousDeath
force-pushed
the
stage3d-set-program-constants-from-byte-array
branch
from
643aa97 to
e44e058
Compare
SuchAFuriousDeath
force-pushed
the
stage3d-set-program-constants-from-byte-array
branch
from
e44e058 to
cc04236
Compare
kjarosh
reviewed
Jan 24, 2026
| ProgramType::Fragment | ||
| } else { | ||
| panic!("Unknown program type {program_type:?}"); | ||
| return Err(make_error_2008(activation, "programType")); |
Member
There was a problem hiding this comment.
Can we cover those uncovered lines with tests too?
Collaborator
Author
There was a problem hiding this comment.
I was intending to, guess I missed this one.
SuchAFuriousDeath
removed
the
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The image for the tests is taken from an existing stage3d_rotating_cube test.
The test for invalid inputs also covers setProgramConstantsFromVector with an input that is too small.
Should progress #15007, #15018, #16480, #19499, #20843 (seems to work now) and #22768 (also seems to work now)