-
-
Notifications
You must be signed in to change notification settings - Fork 962
render: Handle negative dest point values in apply_filter properly #22803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
render: Handle negative dest point values in apply_filter properly #22803
Conversation
f93461a to
3234624
Compare
At what tolerance tho? |
|
Dunno. I guess I should try a higher tolerance? I haven't looked into these things too much. The fix should be correct though. |
Always pick the one from FP; if Ruffle is not exact, add tolerance, outliers, multiple checks, etc. This prevents future PRs from changing the image all over the place and makes us exact in comparing FP with Ruffle (and not doing an ocular analysis only). |
tests/tests/swfs/avm2/bitmapdata_applyfilter_destpoint/test.toml
Outdated
Show resolved
Hide resolved
3234624 to
2057910
Compare
2057910 to
2d5fe84
Compare
2d5fe84 to
f538a15
Compare
|
Lmao, you broke it 😂 Give me a while, I'll fix it. |
|
Here is a full list of issues that need to be retested btw. https://github.com/ruffle-rs/ruffle/issues?q=is%3Aissue%20state%3Aopen%20%22would%20end%20up%20overrunning%20the%20bounds%20of%20the%20Destination%20texture%20of%22 |
Head branch was pushed to by a user without write access
f538a15 to
702a808
Compare
Fixes #22792 (and maybe a handful of other issues).
The image is taken from Ruffle itself, hence the no outliers. If taken from Flash, there are like 22k outliers (But visually it looks the same, probably just a filter implementation thing). Not sure which one to pick here.