Skip to content

Conversation

@SuchAFuriousDeath
Copy link
Collaborator

@SuchAFuriousDeath SuchAFuriousDeath commented Jan 19, 2026

Fixes #22792 (and maybe a handful of other issues).

The image is taken from Ruffle itself, hence the no outliers. If taken from Flash, there are like 22k outliers (But visually it looks the same, probably just a filter implementation thing). Not sure which one to pick here.

@SuchAFuriousDeath SuchAFuriousDeath force-pushed the apply-filter-casts branch 2 times, most recently from f93461a to 3234624 Compare January 19, 2026 16:17
@torokati44
Copy link
Member

If taken from Flash, there are like 22k outliers

At what tolerance tho?
🙄 #22008

@SuchAFuriousDeath
Copy link
Collaborator Author

SuchAFuriousDeath commented Jan 19, 2026

Dunno. I guess I should try a higher tolerance? I haven't looked into these things too much. The fix should be correct though.

@SuchAFuriousDeath SuchAFuriousDeath changed the title render: Handle negative dest point values apply_filter properly render: Handle negative dest point values in apply_filter properly Jan 20, 2026
@SuchAFuriousDeath SuchAFuriousDeath added the T-fix Type: Bug fix (in something that's supposed to work already) label Jan 21, 2026
@kjarosh kjarosh added the A-rendering Area: Rendering & Graphics label Jan 24, 2026
@kjarosh
Copy link
Member

kjarosh commented Jan 24, 2026

The image is taken from Ruffle itself, hence the no outliers. If taken from Flash, there are like 22k outliers (But visually it looks the same, probably just a filter implementation thing). Not sure which one to pick here.

Always pick the one from FP; if Ruffle is not exact, add tolerance, outliers, multiple checks, etc. This prevents future PRs from changing the image all over the place and makes us exact in comparing FP with Ruffle (and not doing an ocular analysis only).

@SuchAFuriousDeath SuchAFuriousDeath marked this pull request as draft January 24, 2026 18:27
@SuchAFuriousDeath SuchAFuriousDeath marked this pull request as ready for review January 24, 2026 22:02
@kjarosh kjarosh force-pushed the apply-filter-casts branch from 2d5fe84 to f538a15 Compare January 28, 2026 18:39
@kjarosh kjarosh enabled auto-merge (rebase) January 28, 2026 18:39
@SuchAFuriousDeath
Copy link
Collaborator Author

Lmao, you broke it 😂 Give me a while, I'll fix it.

@SuchAFuriousDeath
Copy link
Collaborator Author

auto-merge was automatically disabled January 28, 2026 19:06

Head branch was pushed to by a user without write access

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rendering Area: Rendering & Graphics T-fix Type: Bug fix (in something that's supposed to work already)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error on https://game120906.konggames.com/games/rosyPenguin/vision-by-proxy-2nd-ed/frame/d2496c26-4fcd-46ae-817d-d1cbc8ec1a90/

3 participants