render: fix jitter #22845
Draft
render: fix jitter #22845
+10
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
It seems that expected output.png in failed tests are also different from flashplayer. Can I just change them to match actual output? |
Collaborator
I think you should add tolerance and outliers to test.toml of the tests such that they pass. Many visual tests already do this, it's unrealistic to match Flash output exactly 1:1. |
SuchAFuriousDeath
added
the
T-fix
kjarosh
reviewed
Jan 24, 2026
| false, // we want to do the filter growth for this object ourselves, to know the offsets | ||
| &context.stage.view_matrix(), | ||
| ); | ||
| bounds = Rectangle { |
Member
There was a problem hiding this comment.
I think you can add a method to rectangle that does that
Member
|
This patch would need an explanation + a test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #12788
fix #12790
fix #12791
fix #14174
fix #15440
fix #19575
fix #20224
fix #21696