desktop: Various fixes to exporting bundles, and tests #22849
+673
−348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user can export a bundle with no files when it refers to a remote content. Previously an error was thrown when there were no files because we were unable to calculate the root directory for the content. Now this error will be thrown only when a local file is referenced and no files are exported.
This module was available only with the "fs" feature, so rename it to fs_helpers, make it private and export needed structs.
When the user names a bundle Foo, the save dialog will propose Foo.ruf as the filename instead of whatever was the original name.
kjarosh
added
A-desktop
kjarosh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
More tests added and the module structure was cleaned up too.
Note: GitHub thinks the diff is large because it doesn't understand that a file has been renamed. It's better to review it commit-by-commit.