avm1: Propagate errors properly when calling setters & improve DisplacementMapFilter.mapPoint's setter
#22872
+111
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling a setter, the error from within the setter is propagated, not ignored.
The setter has various weird behaviors: 1. when a value cannot be coerced to a number, it's coerced to i32::MIN, 2. errors from coercion are propagated after setting the value. It's possible that this behavior is more common---in case similar patterns are used in other places, we might want to restructure the code.
kjarosh
added
A-avm1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling a setter, the error from within the setter is propagated,
not ignored.
The
DisplacementMapFilter.mapPoint's setter has various weird behaviors:It's possible that this behavior is more common---in case similar
patterns are used in other places, we might want to restructure the
code.