Skip to content

chore: Update hashbrown to 0.16.1 #22879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
SuchAFuriousDeath wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: Update hashbrown to 0.16.1 #22879

SuchAFuriousDeath wants to merge 1 commit into from
+188 −162

Conversation

@SuchAFuriousDeath
Copy link
Collaborator

@SuchAFuriousDeath SuchAFuriousDeath commented Jan 29, 2026 •
edited
Loading

Now there are only 2 versions of hashbrown instead of 3. This also allows implementing the 'add proper entry API?' TODO easily and removing a lot of unsafe code.

@SuchAFuriousDeath
Copy link
Collaborator Author

SuchAFuriousDeath commented Jan 29, 2026

Forgot to run tests locally :(

@SuchAFuriousDeath SuchAFuriousDeath force-pushed the hashbrown-0.15 branch 2 times, most recently from 015c2d3 to e6c8f8c Compare January 30, 2026 10:10
@torokati44
Copy link
Member

torokati44 commented Jan 30, 2026

Won't we need to jump straight to 0.16? @moulins

Screenshot_20260130-111342

@torokati44
Copy link
Member

torokati44 commented Jan 30, 2026

Or 0.16.1 even.
Screenshot_20260130-111625

@torokati44
Copy link
Member

torokati44 commented Jan 30, 2026 •
edited
Loading

Also indexmap might be useful, but I dunno.

torokati44
torokati44 reviewed Jan 30, 2026
View reviewed changes
@SuchAFuriousDeath
Copy link
Collaborator Author

SuchAFuriousDeath commented Jan 30, 2026 •
edited
Loading

Won't we need to jump straight to 0.16? @moulins
Screenshot_20260130-111342

We do, the description is now inaccurate, because I had to upgrade to 0.16 to make the tests pass because 0.15 does not have the bucket api on HashTable.

@SuchAFuriousDeath SuchAFuriousDeath changed the title chore: Update hashbrown to 0.15 chore: Update hashbrown to 0.16.1 Jan 30, 2026
@SuchAFuriousDeath SuchAFuriousDeath mentioned this pull request Jan 30, 2026
Merged
@kjarosh kjarosh added A-deps Area: Dependencies T-chore Type: Chore (like updating a dependency, it's gotta be done) labels Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@torokati44 torokati44 torokati44 left review comments

Assignees

No one assigned

Labels

A-deps Area: Dependencies T-chore Type: Chore (like updating a dependency, it's gotta be done)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SuchAFuriousDeath @torokati44 @kjarosh