core: Cleanup some SwfSlice/buffer::Slice code#23124
Open
moulins wants to merge 6 commits intoruffle-rs:masterfrom
Open
core: Cleanup some SwfSlice/buffer::Slice code#23124moulins wants to merge 6 commits intoruffle-rs:masterfrom
SwfSlice/buffer::Slice code#23124moulins wants to merge 6 commits intoruffle-rs:masterfrom
Conversation
Either the parent slice pointed to an entire movie, or the subslice was known to be in the current tag; in both case, `to_unbounded_subslice` is unnecessary.
Consumers can always get it directly from the passed-in reader if needed.
Every caller was passing in the length of the reader; furthermore, readers are always in bound of the current `SwfSlice`, so the method can be simplified to forward to `SwfSlice::to_subslice`.
moulins
added
A-core
We can implement `io::Read` on `Slice` directly.
There were only to callers, and they could both be replaced by something simpler.
moulins
force-pushed
the
slice-logic-cleanup
branch
from
7cf3f18 to
afa2039
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SwfSlice::to_subsliceinstead ofto_unbounded_subsliceoutside of AVM1 bytecode (which is the only place that needs to allow whole-movie access not restricted to the current tag);decode_tags's callback &SwfSlice::resize_to_reader;io::Readonbuffer::Slicedirectly (instead ofbuffer::SliceCursor);