tests: Test more classes in avm1/native_objects_swf*.#23130
Open
moulins wants to merge 1 commit intoruffle-rs:masterfrom
Open
tests: Test more classes in avm1/native_objects_swf*.#23130moulins wants to merge 1 commit intoruffle-rs:masterfrom
avm1/native_objects_swf*.#23130moulins wants to merge 1 commit intoruffle-rs:masterfrom
Conversation
Of note: - Some objects have a read-only `__proto__`, requring a call to `ASSetPropFlags` before their nativeness can be tested. - Even with the above work-around, `NetConnection` objects refuse to have their `__proto__` modified.
moulins
added
A-tests
kjarosh
reviewed
Feb 28, 2026
| new SharedObject() /* not a class */: non-native | ||
| new Sound(): native | ||
| new Sound(2): native | ||
| new Sound(_root): native |
Member
There was a problem hiding this comment.
Based on the discussion on Discord, we could add new Sound(unloadedMovie) here?
kjarosh
approved these changes
Feb 28, 2026
kjarosh
removed
the
waiting-on-review
kjarosh
added
the
waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Of note:
__proto__, requring a call toASSetPropFlagsbefore their nativeness can be tested.NetConnectionobjects refuse to have their__proto__modified.Possibly related to this comment in #22920.