Investigate and propose fix for github issue 2219 #2286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Call to a member function hasConnection() on nullinBulk.phpby replacing removed Connection API calls with a configuration-based approach.The error was introduced in Elastica 7.3.2 when new code in
src/Bulk.php(forretryOnConflictlogic) attempted to useClient::hasConnection()andClient::getConnection(). These methods were part of theElastica\Connectionclass which was removed in Elastica 8.0, but the problematic code was backported to 7.3.2 without adapting to the new configuration-based approach, leading to a fatal error. This PR applies the correct configuration-based logic already present in the 9.x branch.