Skip to content

chore: PHP 8.4 preparation #2297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
signor-pedro wants to merge 5 commits into from
Closed

chore: PHP 8.4 preparation #2297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cd0bec0
Update composer.json
michalbrauner Dec 5, 2017
a43676a
Merge remote-tracking branch 'upstream/master'
janveselynet Nov 19, 2018
c9aee74
DE-57584: Configure GHA for Black Duck scanning.
nclemons78 Jul 20, 2023
9a80b4e
Merge pull request #12 from BrandEmbassy/DE-57584-black-duck
nclemons78 Aug 21, 2023
08b0f78
chore: test commit to verify CI pipeline triggers
signor-pedro Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions .github/workflows/blackduck.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
name: blackduck

on:
push:
branches:
- master
schedule:
# Execute at 00:00 on 1st day of every month
- cron: '0 0 1 * *'
Comment on lines +3 to +9
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description mentions verifying which CI pipelines are triggered on PRs, but this workflow only runs on push to master and on a schedule. If you need PR validation/trigger testing, add a pull_request and/or workflow_dispatch trigger (keeping secrets usage in mind for PR runs).

Copilot uses AI. Check for mistakes.

jobs:
# A job to execute a blackduck scan
blackduck:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/checkout@v2 is quite old and may hit GitHub Actions runtime deprecations (Node runtime updates) sooner than newer major versions. Consider upgrading to actions/checkout@v4 to reduce the chance of workflow breakage and to stay aligned with current GitHub-recommended versions.

Suggested change
- uses: actions/checkout@v2
- uses: actions/checkout@v4

Copilot uses AI. Check for mistakes.

- name: Run Synopsys Detect
uses: synopsys-sig/detect-action@v0.3.0
env:
DETECT_TOOLS: DETECTOR
DETECT_PROJECT_NAME: ${{ github.repository }}
NODE_EXTRA_CA_CERTS: ${{ secrets.LOCAL_CA_CERT_PATH }}
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
detect-version: 7.9.0
blackduck-url: https://nice2.app.blackduck.com/
blackduck-api-token: ${{ secrets.BLACKDUCK_API_TOKEN }}
scan-mode: INTELLIGENT
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Elastica: elasticsearch PHP Client
==================================
Elastica: elasticsearch PHP Client - PHP 8.4 preparation
=========================================================

[![Latest Stable Version](https://poser.pugx.org/ruflin/Elastica/v/stable.png)](https://packagist.org/packages/ruflin/elastica)
[![Build Status](https://secure.travis-ci.org/ruflin/Elastica.png?branch=master)](http://travis-ci.org/ruflin/Elastica)
Comment on lines +1 to 5
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README title now claims "PHP 8.4 preparation", but the document (badges/links and the compatibility table) still points to ruflin/Elastica and indicates PHP ^7.0 support. This is misleading; either update the related links/compatibility info to match the new package/repo direction or remove the PHP 8.4 note until the actual compatibility work lands.

Copilot uses AI. Check for mistakes.
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "ruflin/elastica",
"name": "brandembassy/elastica",
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the Composer package name from "ruflin/elastica" to "brandembassy/elastica" is a breaking change for downstream consumers (install/upgrade paths, Packagist metadata, and any references in docs/CI). If this repo is intended to remain a fork, consider keeping the original package name (or clearly documenting the new install name and ensuring the old name is not referenced elsewhere).

Suggested change
"name": "brandembassy/elastica",
"name": "ruflin/elastica",

Copilot uses AI. Check for mistakes.
"description": "Elasticsearch Client",
"keywords": ["search","client"],
"homepage": "http://elastica.io/",
Expand Down
Loading