Improve texts if user group has no twitter account #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some texts assumed that every user group has a twitter account which might sometimes not be the case. For example the dresden.rb user group does not have a twitter account (at least not yet). This change removes the "requirement" and improves the site if no twitter account was given.
salzig
reviewed
Oct 31, 2024
|
Thanks for the PR. Had the same thought when dresdenrb got added. |
richardboehme
force-pushed
the
rb/improve-ug-without-twitter
branch
from
53e6c99 to
060f13e
Compare
|
@salzig Sorry to ping, is there anything I can do to move this further? |
JoschkaSchulz
approved these changes
Nov 27, 2024
salzig
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some texts assumed that every user group has a twitter account which might sometimes not be the case. For example the dresden.rb user group does not have a twitter account (at least not yet). This change removes the "requirement" and improves the site if no twitter account was given.