Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve texts if user group has no twitter account #1077

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

richardboehme
Copy link
Contributor

Some texts assumed that every user group has a twitter account which might sometimes not be the case. For example the dresden.rb user group does not have a twitter account (at least not yet). This change removes the "requirement" and improves the site if no twitter account was given.

Some texts assumed that every user group has a twitter account which
might sometimes not be the case. For example the dresden.rb user group
does not have a twitter account (at least not yet). This change removes
the "requirement" and improves the site if no twitter account was given.
@salzig
Copy link
Collaborator

salzig commented Oct 31, 2024

Thanks for the PR. Had the same thought when dresdenrb got added.

@richardboehme richardboehme force-pushed the rb/improve-ug-without-twitter branch from 53e6c99 to 060f13e Compare October 31, 2024 16:34
@richardboehme
Copy link
Contributor Author

@salzig Sorry to ping, is there anything I can do to move this further?

@salzig salzig merged commit 2e4ab08 into rughh:master Nov 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants