Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: skip roundtrip via database for organizers predicate #1080

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

salzig
Copy link
Collaborator

@salzig salzig commented Nov 4, 2024

Every User Card checks if the currently displayed user is one of the organisers to show the organiser badge. Before we used the Scope which fetches the User Objects matching the Organizer Nicknames to check if the current user is in that list. After we check if the current user nickname is part of the Organizer Nicknames, without asking the database for the users.

Edit:
shaves off about 0.3ms per user attending.

@salzig salzig requested a review from JoschkaSchulz November 4, 2024 17:29
@JoschkaSchulz JoschkaSchulz merged commit 45b870e into master Nov 27, 2024
1 check passed
@JoschkaSchulz JoschkaSchulz deleted the perf/skip_roundtrip_via_database branch November 27, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants