Update custom occurence for dresdenrb #1086
Conversation
config/locales/de.label.yml
Outdated
| @@ -124,4 +124,4 @@ de: | |||
| :title: Dresden.rb | |||
| :subtitle: Ruby User Group Dresden | |||
| :meta_desc: Die neue Ruby User Group in Dresden | |||
| :custom_recurrence: Erster Termin am 28.11.2024 | |||
| :custom_recurrence: aller drei Monate | |||
There was a problem hiding this comment.
| :custom_recurrence: aller drei Monate | |
| :custom_recurrence: alle drei Monate |
There was a problem hiding this comment.
Thank you! We can squash the PR if you want.
There was a problem hiding this comment.
I would love better commit messages. ;)
There was a problem hiding this comment.
Do you prefer a commit for this fixup with a better message vs one commit for the whole PR with the fix included? I'd normally squash this but I can also write a small commit message for this fixup.
There was a problem hiding this comment.
There is nothing to squash when there is only one commit/change and no one benefits from fix commits within a branch that introduces the change.
To be honest, I would have amended the typo fix without even asking.
There was a problem hiding this comment.
Yeah I was just lazy and used the "Commit suggestion" button from Github and thought it'd be easy to squash with Github's squash merge. I did the rebase manually now.
This adds the custom recurrence text to other translations as they were previously inside the "meta_desc" translation and updates the text to reflect the three months meetup cycle that we plan to achieve.
richardboehme
force-pushed
the
rb/dresdenrb-update-occurence
branch
from
d1b6c81 to
fe55019
Compare
This adds the custom recurrence text to other translations as they were previously inside the "meta_desc" translation and updates the text to reflect the three months meetup cycle that we plan to achieve.
The translations were done using deepl, so I hope they are fine.