Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update custom occurence for dresdenrb #1086

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

richardboehme
Copy link
Contributor

This adds the custom recurrence text to other translations as they were previously inside the "meta_desc" translation and updates the text to reflect the three months meetup cycle that we plan to achieve.

The translations were done using deepl, so I hope they are fine.

@@ -124,4 +124,4 @@ de:
:title: Dresden.rb
:subtitle: Ruby User Group Dresden
:meta_desc: Die neue Ruby User Group in Dresden
:custom_recurrence: Erster Termin am 28.11.2024
:custom_recurrence: aller drei Monate
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:custom_recurrence: aller drei Monate
:custom_recurrence: alle drei Monate

Copy link
Contributor Author

@richardboehme richardboehme Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! We can squash the PR if you want.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love better commit messages. ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you prefer a commit for this fixup with a better message vs one commit for the whole PR with the fix included? I'd normally squash this but I can also write a small commit message for this fixup.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is nothing to squash when there is only one commit/change and no one benefits from fix commits within a branch that introduces the change.

To be honest, I would have amended the typo fix without even asking.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I was just lazy and used the "Commit suggestion" button from Github and thought it'd be easy to squash with Github's squash merge. I did the rebase manually now.

This adds the custom recurrence text to other translations as they were
previously inside the "meta_desc" translation and updates the text to
reflect the three months meetup cycle that we plan to achieve.
@richardboehme richardboehme force-pushed the rb/dresdenrb-update-occurence branch from d1b6c81 to fe55019 Compare December 3, 2024 17:14
@richardboehme richardboehme requested a review from salzig December 5, 2024 13:07
@salzig salzig merged commit 29bc4d9 into rughh:master Dec 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants