Use next event as the "current" event #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes the restriction of the current event to be at most 9 weeks in the future. Some user groups might decide to hold meetups less frequently so this limitation prevents them from advertising their next event until 9 weeks before the meetup. With this change the current event that is displayed on the homepage will always be the next event, even if it's set far in the future. Closes rughh#1084
phoet
requested changes
Dec 3, 2024
salzig
reviewed
Dec 3, 2024
richardboehme
force-pushed
the
rb/update-current-event
branch
from
e33b0d8 to
58df187
Compare
richardboehme
force-pushed
the
rb/update-current-event
branch
from
58df187 to
403ffe3
Compare
salzig
approved these changes
Dec 5, 2024
JoschkaSchulz
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know if you like the change or not. We already discussed a bit in #1084 and I feel like the artificial limit does not make much sense. If you feel like this changes behavior too much though, feel free to close this. I just had some free time and figured I create a PR for this to move forward. Maybe another solution would be better or maybe we don't want to change this at all.
This change removes the restriction of the current event to be at most 9 weeks in the future. Some user groups might decide to hold meetups less frequently so this limitation prevents them from advertising their next event until 9 weeks before the meetup.
With this change the current event that is displayed on the homepage will always be the next event, even if it's set far in the future.
Closes #1084