Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use next event as the "current" event #1087

Merged
merged 2 commits into from
Jan 26, 2025

Conversation

richardboehme
Copy link
Contributor

Let me know if you like the change or not. We already discussed a bit in #1084 and I feel like the artificial limit does not make much sense. If you feel like this changes behavior too much though, feel free to close this. I just had some free time and figured I create a PR for this to move forward. Maybe another solution would be better or maybe we don't want to change this at all.

This change removes the restriction of the current event to be at most 9 weeks in the future. Some user groups might decide to hold meetups less frequently so this limitation prevents them from advertising their next event until 9 weeks before the meetup.

With this change the current event that is displayed on the homepage will always be the next event, even if it's set far in the future.

Closes #1084

This change removes the restriction of the current event to be at most 9
weeks in the future. Some user groups might decide to hold meetups less
frequently so this limitation prevents them from advertising their next
event until 9 weeks before the meetup.

With this change the current event that is displayed on the homepage
will always be the next event, even if it's set far in the future.

Closes rughh#1084
Copy link
Member

@phoet phoet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with changing this semantic if the current organizers are ok with it.

@richardboehme richardboehme force-pushed the rb/update-current-event branch from e33b0d8 to 58df187 Compare December 3, 2024 16:20
@richardboehme richardboehme force-pushed the rb/update-current-event branch from 58df187 to 403ffe3 Compare December 5, 2024 13:05
@salzig salzig merged commit a6f1bd2 into rughh:master Jan 26, 2025
1 check passed
@richardboehme richardboehme deleted the rb/update-current-event branch February 17, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusion about next and current event
4 participants