-
Notifications
You must be signed in to change notification settings - Fork 132
Added unit tests #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
atharvarajurkar
wants to merge
1
commit into
rugk:main
Choose a base branch
from
atharvarajurkar:master
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Added unit tests #283
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| import "https://unpkg.com/mocha@5.2.0/mocha.js"; /* globals mocha */ | ||
| import "https://unpkg.com/chai@4.1.2/chai.js"; /* globals chai */ | ||
|
|
||
| import * as BrowserCommunicationTypes from "/common/modules/data/BrowserCommunicationTypes.js"; | ||
|
|
||
|
|
||
| describe("common data: BrowserCommunicationTypes", function () { | ||
| describe("COMMUNICATION_MESSAGE_TYPE", function () { | ||
| it("is there", function () { | ||
| chai.assert.exists(BrowserCommunicationTypes.COMMUNICATION_MESSAGE_TYPE); | ||
| chai.assert.isNotEmpty(BrowserCommunicationTypes.COMMUNICATION_MESSAGE_TYPE); | ||
| }); | ||
|
|
||
| it("is object", function () { | ||
| chai.assert.isObject(BrowserCommunicationTypes.COMMUNICATION_MESSAGE_TYPE); | ||
| }); | ||
|
|
||
| it("is frozen", function () { | ||
| chai.assert.isFrozen(BrowserCommunicationTypes.COMMUNICATION_MESSAGE_TYPE); | ||
| }); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| import "https://unpkg.com/mocha@5.2.0/mocha.js"; /* globals mocha */ | ||
| import "https://unpkg.com/chai@4.1.2/chai.js"; /* globals chai */ | ||
|
|
||
| import isFunction from "/common/modules/lodash/isFunction.js"; | ||
|
|
||
| describe("common lodash: isFunction", function () { | ||
|
|
||
| it("method is a function", function () { | ||
| /** | ||
| * Dummy function | ||
| * @returns {number}. | ||
| */ | ||
| function Foo() { | ||
| return 1 + 2; | ||
| } | ||
| chai.assert.isTrue(isFunction(Foo)); | ||
| }); | ||
|
|
||
| it("null is not function", function () { | ||
| chai.assert.isFalse(isFunction(null)); | ||
| }); | ||
|
|
||
| it("list is not function", function () { | ||
| chai.assert.isFalse(isFunction([1,2,3])); | ||
| }); | ||
|
|
||
|
|
||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| import "https://unpkg.com/mocha@5.2.0/mocha.js"; /* globals mocha */ | ||
| import "https://unpkg.com/chai@4.1.2/chai.js"; /* globals chai */ | ||
|
|
||
| import isObjectLike from "/common/modules/lodash/isObjectLike.js"; | ||
|
|
||
| describe("common lodash: isObjectLike", function () { | ||
|
|
||
| it("method is like object", function () { | ||
| /** | ||
| * Dummy function | ||
| * @returns {number}. | ||
| */ | ||
| function Foo() { | ||
| return 1 + 2; | ||
| } | ||
| chai.assert.isTrue(isObjectLike(new Foo)); | ||
| }); | ||
|
|
||
| it("null is not object", function () { | ||
| chai.assert.isFalse(isObjectLike(null)); | ||
| }); | ||
|
|
||
| it("list is like object", function () { | ||
| chai.assert.isTrue(isObjectLike([1,2,3])); | ||
| }); | ||
|
|
||
| it("JSON is like object", function () { | ||
| chai.assert.isTrue(isObjectLike({})); | ||
| }); | ||
|
|
||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| import "https://unpkg.com/mocha@5.2.0/mocha.js"; /* globals mocha */ | ||
| import "https://unpkg.com/chai@4.1.2/chai.js"; /* globals chai */ | ||
|
|
||
| import isPlainObject from "/common/modules/lodash/isPlainObject.js"; | ||
|
|
||
| describe("common lodash: isPlainObject", function () { | ||
|
|
||
| it("method is not plain object", function () { | ||
| /** | ||
| * Dummy function | ||
| * @returns {number}. | ||
| */ | ||
| function Foo() { | ||
| return 1 + 2; | ||
| } | ||
| chai.assert.isFalse(isPlainObject(new Foo)); | ||
| }); | ||
|
|
||
| it("list is not plain object", function () { | ||
| chai.assert.isFalse(isPlainObject([1, 2, 3])); | ||
| }); | ||
|
|
||
| it("JSON object is plain object", function () { | ||
| chai.assert.isTrue(isPlainObject({ "x": 0, "y": 0 })); | ||
| }); | ||
|
|
||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| import "https://unpkg.com/mocha@5.2.0/mocha.js"; /* globals mocha */ | ||
| import "https://unpkg.com/chai@4.1.2/chai.js"; /* globals chai */ | ||
|
|
||
| import isString from "/common/modules/lodash/isString.js"; | ||
|
|
||
| describe("common lodash: isString", function () { | ||
|
|
||
| it("character is a String", function () { | ||
| chai.assert.isTrue(isString('testCharacters')); | ||
| }); | ||
|
|
||
| it("method is not a String", function () { | ||
| /** | ||
| * Dummy function | ||
| * @returns {number}. | ||
| */ | ||
| function Foo() { | ||
| return 1 + 2; | ||
| } | ||
| chai.assert.isFalse(isString(Foo)); | ||
| }); | ||
|
|
||
| it("null is not a String", function () { | ||
| chai.assert.isFalse(isString(null)); | ||
| }); | ||
|
|
||
| it("number is not a String", function () { | ||
| chai.assert.isFalse(isString(12)); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a very good intent, but I doubt we need to test lodash modules again. They are teted by lodash already and may/are in the future even considered to be dropped: https://github.com/TinyWebEx/AddonTemplate/issues/7
But sure this was a good test to do,
Same goes for the other files.
BrowserCommunicationTypesis a thing I would keep, the other ones are kinda redundant.