Fix segfault (null deref) in named initialisation of nested anonymous union#156
Open
el-remph wants to merge 1 commit intorui314:mainfrom
Open
Fix segfault (null deref) in named initialisation of nested anonymous union#156el-remph wants to merge 1 commit intorui314:mainfrom
el-remph wants to merge 1 commit intorui314:mainfrom
Conversation
|
IMO unnamed bitfields should be filtered out earlier though. |
f7f4305 to
f17f6be
Compare
Author
|
@fuhsnn Thanks, I hadn't thought of that. Added that to the test, and fixed the code to allow it, and still prevent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems very specific but I did happen upon it organically. What were the chances? lol
Also adds a regression test, which causes previous chibicc version to deref NULL and segfault (the cc1 process dies with SIGSEGV, which causes the driver to
exit(1)).I think I'm right to assume that the only way
mem->namecan be NULL is ifmemis an anonymous union/struct? Just wanted to make sure