Skip to content

Discard section#1423

Merged
rui314 merged 2 commits intorui314:mainfrom
christycylee:discard-section
Mar 5, 2025
Merged

Discard section#1423
rui314 merged 2 commits intorui314:mainfrom
christycylee:discard-section

Conversation

@christycylee
Copy link
Contributor

This is equivalent to discarding a section via /DISCARD/ in linker scripts.

@rui314
Copy link
Owner

rui314 commented Mar 5, 2025

I'd hide this option from the help message as this is an experimental option. I don't want to commit for maintaining it forever at this moment until all the features you need are ready and proved to work nicely.

Do you really need --no-discard-section? We have --foo and --no-foo for boolean options, but options that take an argument rarely have counterpart --no- options.

@christycylee
Copy link
Contributor Author

Do you really need --no-discard-section? We have --foo and --no-foo for boolean options, but options that take an argument rarely have counterpart --no- options.

Unfortunately yes, we need positional overrides here :(

@rui314
Copy link
Owner

rui314 commented Mar 5, 2025

OK, then let's give it a shot.

@rui314 rui314 merged commit ec36076 into rui314:main Mar 5, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants