Skip to content

Remove extraneous build files#1425

Merged
rui314 merged 1 commit intorui314:mainfrom
christycylee:buck_files
Mar 11, 2025
Merged

Remove extraneous build files#1425
rui314 merged 1 commit intorui314:mainfrom
christycylee:buck_files

Conversation

@christycylee
Copy link
Contributor

mold uses cmake, the BUCK files from zstd are not needed.

@rui314
Copy link
Owner

rui314 commented Mar 8, 2025

I just copied the entire source tree of zstd to our third-party directory. All of their files may not be needed, but still we can keep them, can't we?

@christycylee
Copy link
Contributor Author

The BUCK files are malformed which breaks repos that use buck builds by default. I'm also happy to fix the BUCK files if that's better.

@rui314
Copy link
Owner

rui314 commented Mar 11, 2025

Let's remove them for now. Do you mind if I ask you to fix it in upstream (https://github.com/facebook/zstd) so that the issue is resolved completely?

@rui314 rui314 merged commit 0061d53 into rui314:main Mar 11, 2025
15 checks passed
@christycylee
Copy link
Contributor Author

Do you mind if I ask you to fix it in upstream

For sure!

@rui314
Copy link
Owner

rui314 commented Mar 12, 2025

I'm not sure what these build files are for, but if they are malformed and cannot be used, you may want to remove them from upstream instead of fixing them. If they are unusable, these files have no users.

For tracking purpose, refer to this PR when you make a new PR for the upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants