Skip to content

Isolate Rust implementation under top-level rust/ directory - #1

Merged
adulau merged 1 commit into
mainfrom
codex/organize-rust-implementation-in-dedicated-directory
Sep 1, 2026
Merged

Isolate Rust implementation under top-level rust/ directory#1
adulau merged 1 commit into
mainfrom
codex/organize-rust-implementation-in-dedicated-directory

Conversation

@adulau

@adulau adulau commented Sep 1, 2026

Copy link
Copy Markdown
Member

Motivation

  • Keep all Rust crates, Cargo manifests, and Rust source files in a single top-level directory so Cargo workspaces and tooling do not get mixed with the Python package.

Description

  • Add rust/README.md documenting that all Rust sources, Cargo.toml, Cargo.lock, and *.rs files must live under rust/.
  • Add tests/test_repository_layout.py which fails if any *.rs, Cargo.toml, or Cargo.lock file is found outside rust/.
  • Update CONTRIBUTING.md to document the repository layout and the rust/ boundary.
  • Update .gitignore to ignore Cargo build output by adding target/.

Testing

  • Ran git diff --check which produced no whitespace or index errors.
  • Ran PYTHONPATH=src python -m pytest -m 'not network' -q and the suite passed with 26 passed, 2 skipped.
  • Ran python -m ruff check src tests and lint checks completed without failures.

Codex Task

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-01T08:36:13.195881Z 9fe5534 PR opened
🔒 Security Review Completed 2026-09-01T08:37:59.490567Z 9fe5534 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@adulau
adulau merged commit c3fd717 into main Sep 1, 2026
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant