fix: respect cleanPodPolicy when job exceeds backoffLimit#9
Open
AviadHayumi wants to merge 1 commit intorelease-1.9from
Open
fix: respect cleanPodPolicy when job exceeds backoffLimit#9AviadHayumi wants to merge 1 commit intorelease-1.9from
AviadHayumi wants to merge 1 commit intorelease-1.9from
Conversation
Move UpdateJobConditions(JobFailed) before DeletePodsAndServices in the jobExceedsLimit block so that IsFinished() returns true and the cleanPodPolicy: None guard is not bypassed. Fixes: kubeflow#3419 Signed-off-by: Aviad Hayumi <aviad.hayumi@run.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
backoffLimit, pods are deleted regardless ofcleanPodPolicy: NoneDeletePodsAndServices()is called beforeJobFailedcondition is set, so thecleanPodPolicy: Noneguard is bypassedUpdateJobConditions(JobFailed)beforeDeletePodsAndServices()Upstream issue: kubeflow#3419
Upstream PR: kubeflow#3420
Test plan
go test ./pkg/controller.v1/common/)cleanPodPolicy: None+backoffLimit: 1— pods preserved after failure