Support multi tenant #1930
Open
Support multi tenant #1930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BelSasha
force-pushed
the
sb/multi-tenant-support
branch
from
2831a98 to
39005f6
Compare
jlewitt1
reviewed
Nov 25, 2025
| location ^~ /prometheus/ { | ||
| resolver {{ .Values.nginx.resolver }} valid=5s; | ||
| set $prom_host "kubetorch-metrics.{{ .Release.Namespace }}.svc.cluster.local:{{ .Values.metrics.prometheus.port }}"; | ||
| set $prom_host "{{ .Values.metrics.metricsServiceName }}.{{ if eq .Values.metrics.metricsServiceName "kubetorch-metrics" }}{{ .Release.Namespace }}{{ else }}platform{{ end }}.svc.cluster.local:{{ .Values.metrics.prometheus.port }}"; |
Collaborator
There was a problem hiding this comment.
can remove the if else logic here and just use --set metrics.metricsServiceName when installing?
jlewitt1
reviewed
Nov 25, 2025
| location ^~ {{ .Values.nginxProxy.backends.logging.route }}/ { | ||
| resolver {{ .Values.nginx.resolver }} valid=5s; | ||
| set $loki_host "loki-gateway.{{ .Release.Namespace }}.svc.cluster.local:{{ .Values.logStreaming.port }}"; | ||
| set $loki_host "loki-gateway.{{ if eq .Values.logStreaming.port 3100 }}{{ .Release.Namespace }}{{ else }}platform{{ end }}.svc.cluster.local:{{ .Values.logStreaming.port }}"; |
BelSasha
force-pushed
the
sb/multi-tenant-support
branch
3 times, most recently
from
2375539 to
a3fafe5
Compare
BelSasha
force-pushed
the
sb/multi-tenant-support
branch
from
a3fafe5 to
b28683d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.