Trainer V2 #1976
Open
Trainer V2 #1976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alexandra Belousov <[email protected]>
Co-authored-by: Alexandra Belousov <[email protected]>
add support for handling byo manifest in compute init, for existing service types (deployment, ksvc, raycluster), and supplement with kubetorch defaults, env vars, and formatting. additional kwargs will override manifest values * extract user values from byo manifest * generate new pod template and manifest with the following priority: kwargs -> user_value -> kubetorch default * merge new pod spec into original pod spec. override differences, and add in missing components. rest of the user manifest stays the same
generally simplify and unify service manager components. move more things into base service manager and set up for adding new custom service manager
custom service manager for kubeflow type training jobs, only pytorch job just tested currently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.