Skip to content

Conversation

@BelSasha
Copy link
Contributor

No description provided.

@BelSasha BelSasha mentioned this pull request Dec 11, 2025
Copy link
Contributor Author

BelSasha commented Dec 11, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@BelSasha BelSasha force-pushed the sb/profiling-tests branch 3 times, most recently from 27f7cb1 to 224a783 Compare December 11, 2025 20:43
@BelSasha BelSasha changed the base branch from sb/torch-profiling to graphite-base/1977 December 14, 2025 10:40
@BelSasha BelSasha changed the base branch from graphite-base/1977 to sb/torch-profiling December 14, 2025 10:41
@BelSasha BelSasha marked this pull request as ready for review December 15, 2025 16:12
@BelSasha BelSasha force-pushed the sb/profiling-tests branch 2 times, most recently from 3526a3d to 810132f Compare December 16, 2025 16:13
return remote_fn


@pytest.fixture(scope="session")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in these tests how come we're not passing in the profiler arg?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we pass them during the call to the remote workload, the same as we pass loggingConfig, MetricsConfig or DebugConfig.

@BelSasha BelSasha changed the base branch from sb/torch-profiling to graphite-base/1977 December 17, 2025 11:06
@BelSasha BelSasha changed the base branch from graphite-base/1977 to sb/torch-profiling December 17, 2025 11:09
@BelSasha BelSasha force-pushed the sb/profiling-tests branch 2 times, most recently from 3d778ee to 98e96bc Compare December 17, 2025 12:23
@BelSasha BelSasha requested a review from jlewitt1 December 17, 2025 12:52
@BelSasha BelSasha force-pushed the sb/torch-profiling branch 2 times, most recently from 4eccbde to 5b7e6be Compare December 22, 2025 14:56
@BelSasha BelSasha force-pushed the sb/profiling-tests branch 2 times, most recently from 01ff3af to 875981b Compare December 23, 2025 10:28
@BelSasha BelSasha force-pushed the sb/torch-profiling branch 2 times, most recently from 4023fad to 16861aa Compare December 24, 2025 12:42
@BelSasha BelSasha force-pushed the sb/profiling-tests branch 2 times, most recently from 22d355f to 8c2540f Compare December 24, 2025 13:00
@BelSasha BelSasha force-pushed the sb/torch-profiling branch 2 times, most recently from b7f1f47 to 219fd65 Compare December 24, 2025 13:58
@BelSasha BelSasha force-pushed the sb/profiling-tests branch 3 times, most recently from fda228f to e873b25 Compare December 24, 2025 15:54
@BelSasha BelSasha force-pushed the sb/torch-profiling branch 2 times, most recently from 00b4355 to f19207f Compare December 24, 2025 15:57
@BelSasha BelSasha changed the base branch from sb/torch-profiling to graphite-base/1977 December 24, 2025 16:01
@BelSasha BelSasha changed the base branch from graphite-base/1977 to sb/torch-profiling December 24, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants