Add and use deploy and discover routes for controller #2041
+369
−491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
jlewitt1
reviewed
Dec 28, 2025
python_client/kubetorch/globals.py
Outdated
| For special cases (selector-only, BYO manifests), use apply() and register_pool() separately. | ||
| Args: | ||
| service_name: Name of the service |
Collaborator
There was a problem hiding this comment.
dumb nit - can we keep these docstrings consistent with google style and include the type in parenthesis
Collaborator
Author
There was a problem hiding this comment.
yes but I think all the docstrings in service_manager and globals are all currently this format 😓 I think it's worth doing a larger docstring cleanup PR separately when the branch is somewhat stable
jlewitt1
reviewed
Dec 28, 2025
jlewitt1
reviewed
Dec 28, 2025
jlewitt1
reviewed
Dec 28, 2025
jlewitt1
reviewed
Dec 28, 2025
carolineechen
force-pushed
the
manifest-in-manager
branch
2 times, most recently
from
3d6109b to
c3de76a
Compare
carolineechen
force-pushed
the
controller-routes
branch
2 times, most recently
from
7fa2bd9 to
71d7d25
Compare
Base automatically changed from
manifest-in-manager
to
apply-and-pool-endpoints
December 29, 2025 22:20
carolineechen
changed the base branch from
apply-and-pool-endpoints
to
graphite-base/2041
carolineechen
force-pushed
the
controller-routes
branch
from
71d7d25 to
5f63f6a
Compare
carolineechen
force-pushed
the
graphite-base/2041
branch
from
b33956f to
506f0a0
Compare
carolineechen
force-pushed
the
controller-routes
branch
from
5f63f6a to
2b26a9e
Compare
carolineechen
force-pushed
the
graphite-base/2041
branch
from
5ece2cc to
ec64e44
Compare
carolineechen
changed the base branch from
graphite-base/2041
to
apply-and-pool-endpoints
carolineechen
force-pushed
the
controller-routes
branch
from
2b26a9e to
a06805b
Compare
carolineechen
force-pushed
the
controller-routes
branch
from
a06805b to
3089028
Compare
jlewitt1
force-pushed
the
apply-and-pool-endpoints
branch
2 times, most recently
from
452273e to
67bb817
Compare
dongreenberg
changed the base branch from
apply-and-pool-endpoints
to
graphite-base/2041
carolineechen
force-pushed
the
controller-routes
branch
from
3089028 to
6600abc
Compare
carolineechen
changed the base branch from
graphite-base/2041
to
apply-and-pool-endpoints
carolineechen
force-pushed
the
controller-routes
branch
from
6600abc to
213a316
Compare
dongreenberg
changed the base branch from
apply-and-pool-endpoints
to
graphite-base/2041
carolineechen
force-pushed
the
controller-routes
branch
from
213a316 to
21e67e5
Compare
carolineechen
force-pushed
the
graphite-base/2041
branch
from
80765c6 to
578762f
Compare
carolineechen
force-pushed
the
controller-routes
branch
2 times, most recently
from
0c0023e to
70b7395
Compare
carolineechen
changed the title
carolineechen
force-pushed
the
controller-routes
branch
from
70b7395 to
f55a315
Compare
jlewitt1
approved these changes
Jan 7, 2026
carolineechen
force-pushed
the
controller-routes
branch
from
f55a315 to
8845149
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deployendpoint, which performsapply+poolin a single call rather than 2discover_servicesto fetch all services, alongside optional name or prefix filter. used by kt list and teardown