-
Notifications
You must be signed in to change notification settings - Fork 48
Consolidate service status calls into single API request #2076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
cd102b6 to
8e4f86e
Compare
67bb817 to
80765c6
Compare
8e4f86e to
1f8b4ed
Compare
1f8b4ed to
a28324d
Compare
a28324d to
e2f0a22
Compare
e2f0a22 to
89c692d
Compare
2ed4d35 to
cc9e34b
Compare
89c692d to
22728fa
Compare
cc9e34b to
242488c
Compare
22728fa to
8a4dc6e
Compare
fff95aa to
4251965
Compare
python_client/kubetorch/cli_utils.py
Outdated
| return name, deployment_mode, pods, status | ||
|
|
||
|
|
||
| def get_deployment_mode(name: str, namespace: str) -> tuple: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this function is only being used in kt_describe after this PR, do you think it's worth keeping or just directly replacing the usage with name, deployment_mode, _, _ = get_service_info(name, namespace, require_pods=False)?
4251965 to
6d95474
Compare

Summary
get_service_info()helper that fetches deployment mode, pods, and status in a single controller API callkt check,kt port-forward,kt ssh,kt logs) to use consolidated endpointChanges
globals.py: Addservice_status()method to ControllerClientcli_utils.py: Addget_service_info()helper, updatedetect_deployment_mode()to use new endpointcli.py: Refactorkt_check,kt_port_forward,kt_ssh,kt_logsto useget_service_info()