Update how process groups form with TCPStore instead #2082
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple different requests are made to the same putter, using global env var to set up multiple process groups is bad and leads to one of them trying to work on the wrong port and hanging. TCPStore makes it explicit. (Factored out the setup in multiple methods)
But we still might have multiple requests trying and spin up multiple process groups at the same time. At the cost of worse performance, the simple approach was adding a semaphore. The right approach might be doing work in a process pool and isolating them.