Add Alternate Image Setup Modes (Rsync, Mount) #1702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dongreenberg
changed the title
jlewitt1
reviewed
Jan 22, 2025
| @@ -13,6 +13,20 @@ class ImageSetupStepType(Enum): | |||
| SET_ENV_VARS = "set_env_vars" | |||
|
|
|||
|
|
|||
| class ImageSetupMode(Enum): | |||
There was a problem hiding this comment.
dumb nit, but could initialize this as (str, Enum) which would simplify the strings method to list(cls) I believe, and then remove the need to call .value everywhere
jlewitt1
approved these changes
Jan 22, 2025
dongreenberg
force-pushed
the
add_mounting
branch
from
a7d92c8 to
b56e89e
Compare
dongreenberg
force-pushed
the
image_setup_varieties
branch
from
5dfef93 to
70436a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.