ignore select factory args if pool is provided #1769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
jlewitt1
force-pushed
the
pool-factory-updates
branch
2 times, most recently
from
f85379d to
1879740
Compare
jlewitt1
force-pushed
the
02-11-adds_pool_field_to_ondemand_cluster
branch
from
921ad2d to
a9901fd
Compare
jlewitt1
force-pushed
the
pool-factory-updates
branch
2 times, most recently
from
b1285b0 to
505140c
Compare
jlewitt1
force-pushed
the
pool-factory-updates
branch
from
505140c to
21c9e93
Compare
Base automatically changed from
02-11-adds_pool_field_to_ondemand_cluster
to
main
February 25, 2025 19:57
jlewitt1
force-pushed
the
pool-factory-updates
branch
2 times, most recently
from
0faa465 to
3d467f8
Compare
jlewitt1
force-pushed
the
pool-factory-updates
branch
from
3d467f8 to
9c8fa2e
Compare
jlewitt1
force-pushed
the
pool-factory-updates
branch
from
9c8fa2e to
e7bdf33
Compare
This was referenced Mar 8, 2025
jlewitt1
force-pushed
the
pool-factory-updates
branch
from
e7bdf33 to
c7b37b7
Compare
| @@ -306,6 +306,32 @@ def ondemand_cluster( | |||
| cluster_args = locals().copy() | |||
| cluster_args = {k: v for k, v in cluster_args.items() if v is not None} | |||
|
|
|||
| if pool is not None: | |||
| cluster_args["launcher"] = "den" | |||
There was a problem hiding this comment.
I think we should also catch an error/warning if launcher="local" is specified. Also thoughts on throwing errors throughout this check instead of warnings? To be more explicit and not have anything come as a surprise (e.g. autostop set but not actually enabled) to the user bc they missed a warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.