Fix shell usage in llama-dev changelog command #19957
                
     Merged
            
            
          
      
        
          +15
        
        
          −1
        
        
          
        
      
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This PR addresses a security vulnerability in the
llama-devchangelog generation tool by replacing the unsafeshell=Trueparameter in subprocess calls with proper command parsing usingshlex.split()._run_command()function inllama-dev/llama_dev/release/changelog.pyto parse commands into argument lists usingshlex.split()shell=Trueparameter fromsubprocess.run()calls, preventing potential command injection attacksRisk Level: Low - While this fixes a genuine shell injection vulnerability, the exploitability is limited because:
llama-devtool is a development utility not exposed to external inputs_run_command()are typically hardcoded Git commands within the codebaseThis is a proactive security hardening measure following best practices for subprocess execution, even though the practical exploit risk in this context is minimal.
Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.
Suggested Checklist:
uv run make format; uv run make lintto appease the lint gods