Skip to content

Conversation

MaitreyaBuddha
Copy link
Contributor

Hi! I am looking for conceptual review before I make a PR with an agreed upon approach.

I have added calendar ID option to the list calendars function. This is technically a breaking change. However, in my testing the calendar id "primary" does not work. According to my tests and the documentation, it must be an email:
https://developers.google.com/workspace/calendar/api/concepts/events-calendars#calendars

I would like to take the easy path and use the current approach.
A technically safer approach would be to make a new class that doesn't "break" compatibility with existing consumers.
Or to make a different function.

Thoughts?

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 29, 2025
@MaitreyaBuddha MaitreyaBuddha marked this pull request as draft September 29, 2025 20:39
@MaitreyaBuddha
Copy link
Contributor Author

@logan-markewich Thank you for your help in a previous PR for the google tools integration. Could you please advise what the minimum effort for maintainability best practices is required here? (full ask in PR description)

Copy link
Member

@AstraBert AstraBert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor comments :) 👇

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that we previously used "primary" as an id: can we default to that instead of returning the error?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should move imports at the top of the module

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imports at the top of the module

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming nit: I would probably call it list_all_calendars or get_all_calendars

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants