Skip to content

Conversation

@H2Shami
Copy link
Contributor

@H2Shami H2Shami commented Nov 3, 2025

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I ran uv run make format; uv run make lint to appease the lint gods

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 3, 2025
Comment on lines -11 to +12
"dev:api": "cd api_reference && poetry install && poetry run mkdocs build -d ../.mkdocs/ && npx http-server ../.mkdocs/"
"dev:api": "cd api_reference && poetry install && poetry run mkdocs build -d ../.mkdocs/ && npx http-server ../.mkdocs/",
"dev:all": "sh -c 'pnpm dev & pnpm run dev:api & wait'"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

convenience change

can remove on request

Comment on lines -38 to +41
response = llm.complete("Hello World!")
message: ChatMessage = ChatMessage(role="user", content="Hello world!")
response = helicone.chat(messages=[message])
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to docs was made because helicone does not support the legacy chat api, only chat completions and response

didn't force is_chat_model in the event that the openai_like class changes its default call or adds support for the response api

Comment on lines +5 to +7
# Globally ignore example notebooks under docs/examples/
exclude: ^docs/examples/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-commit was failing for all of the docs/examples, so i just ignored it for future devs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant