feat: add optional embed_model to SemanticDoubleMergingSplitterNodeParser#20748
Open
MkDev11 wants to merge 2 commits intorun-llama:mainfrom
Open
feat: add optional embed_model to SemanticDoubleMergingSplitterNodeParser#20748MkDev11 wants to merge 2 commits intorun-llama:mainfrom
MkDev11 wants to merge 2 commits intorun-llama:mainfrom
Conversation
…plitterNodeParser (Closes run-llama#15041)
Author
|
@AstraBert can you please review the PR and let me know your feedback? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds optional embedding-model support to
SemanticDoubleMergingSplitterNodeParserso users can chunk text in any language (e.g. via Hugging Face / sentence-transformers) without depending on Spacy. Whenembed_modelis set, similarity is computed withBaseEmbedding.get_text_embedding_batchandsimilarity()instead of Spacy; when unset, existing Spacy +LanguageConfigbehavior is unchanged. No new dependencies inllama-index-core; users supply an embedding (e.g.llama-index-embeddings-huggingface) if they want HF.Closes #15041
New Package?
Version Bump?
Type of Change
How Has This Been Tested?
Tests added:
test_embed_model_path_returns_nodes,test_embed_model_similarity_in_range,test_embed_model_single_sentence_documentintests/node_parser/test_semantic_double_merging_splitter.py(useMockEmbedding; no Spacy required).Run:
cd llama-index-core && python3 -m pytest tests/node_parser/test_semantic_double_merging_splitter.py -vSuggested Checklist:
uv run make format; uv run make lintto appease the lint gods