fix(moorcheh): Moorcheh vector store SDK + metadata + tests#21425
Open
Neelpatel1604 wants to merge 6 commits into
Open
fix(moorcheh): Moorcheh vector store SDK + metadata + tests#21425Neelpatel1604 wants to merge 6 commits into
Neelpatel1604 wants to merge 6 commits into
Conversation
Align the Moorcheh integration with current SDK usage, including README install/example fixes and improved metadata handling in the vector store implementation. Expand and stabilize vector store tests to cover real retrieval paths, namespace isolation, filter behavior, and new client method contracts.
…ect.toml and uv.lock
Author
|
@ |
logan-markewich
approved these changes
Apr 22, 2026
Collaborator
|
you'll need to run |
Author
|
@logan-markewich , thanks for the feedback, just run "make lint" and fixed linting error please have a look. If it still persist will fix it! |
Author
|
@logan-markewich , please have a look and let me know if there is any changes required |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
New Package?
Did I fill in the
tool.llamahubsection in thepyproject.tomland provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.
Suggested Checklist:
uv run make format; uv run make lintto appease the lint gods