Skip to content

fix(moorcheh): Moorcheh vector store SDK + metadata + tests#21425

Open
Neelpatel1604 wants to merge 6 commits into
run-llama:mainfrom
moorcheh-ai:main
Open

fix(moorcheh): Moorcheh vector store SDK + metadata + tests#21425
Neelpatel1604 wants to merge 6 commits into
run-llama:mainfrom
moorcheh-ai:main

Conversation

@Neelpatel1604

Copy link
Copy Markdown

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran uv run make format; uv run make lint to appease the lint gods

Align the Moorcheh integration with current SDK usage, including README install/example fixes and improved metadata handling in the vector store implementation. Expand and stabilize vector store tests to cover real retrieval paths, namespace isolation, filter behavior, and new client method contracts.
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Apr 20, 2026
@Neelpatel1604

Copy link
Copy Markdown
Author

@

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Apr 22, 2026
@logan-markewich

Copy link
Copy Markdown
Collaborator

you'll need to run make lint and commit the fixes, or manually read the linting action and fix. I can't push to this PR

@Neelpatel1604

Copy link
Copy Markdown
Author

@logan-markewich , thanks for the feedback, just run "make lint" and fixed linting error please have a look. If it still persist will fix it!

@Neelpatel1604

Copy link
Copy Markdown
Author

@logan-markewich , please have a look and let me know if there is any changes required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants