Skip to content

fix: apply retriever weights in reciprocal rerank fusion#21492

Closed
wolfkill wants to merge 1 commit into
run-llama:mainfrom
wolfkill:codex/llama-index-weighted-rrf
Closed

fix: apply retriever weights in reciprocal rerank fusion#21492
wolfkill wants to merge 1 commit into
run-llama:mainfrom
wolfkill:codex/llama-index-weighted-rrf

Conversation

@wolfkill

@wolfkill wolfkill commented Apr 27, 2026

Copy link
Copy Markdown

Summary

  • Apply retriever_weights when calculating reciprocal rerank fusion scores
  • Preserve the retriever index by iterating over result items instead of values
  • Add a regression test for mode=reciprocal_rerank with a zero-weight retriever

Fixes #21444

Testing

  • UV_CACHE_DIR=.uv-cache uv run --group dev pytest tests/retrievers/test_fusion_retriever.py -q
  • UV_CACHE_DIR=.uv-cache uv run --group dev ruff check llama_index/core/retrievers/fusion_retriever.py tests/retrievers/test_fusion_retriever.py
  • UV_CACHE_DIR=.uv-cache uv run --group dev ruff format --check llama_index/core/retrievers/fusion_retriever.py tests/retrievers/test_fusion_retriever.py

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 27, 2026
@gautamvarmadatla

gautamvarmadatla commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

Hi @wolfkill, thank you so much for working on this. I already created a PR for this along with issue #21445, so we should be covered there.

@github-actions

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 50 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions Bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Jun 19, 2026
@logan-markewich

Copy link
Copy Markdown
Collaborator

This is being closed as a detected duplicate of #21445. If you feel otherwise, feel free to re-open a fresh PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files. stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: QueryFusionRetriever ignores retriever_weights when mode="reciprocal_rerank"

3 participants