fix: apply retriever weights in reciprocal rerank fusion#21492
Closed
wolfkill wants to merge 1 commit into
Closed
Conversation
Contributor
Contributor
|
This PR is stale because it has been open 50 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Collaborator
|
This is being closed as a detected duplicate of #21445. If you feel otherwise, feel free to re-open a fresh PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
retriever_weightswhen calculating reciprocal rerank fusion scoresmode=reciprocal_rerankwith a zero-weight retrieverFixes #21444
Testing
UV_CACHE_DIR=.uv-cache uv run --group dev pytest tests/retrievers/test_fusion_retriever.py -qUV_CACHE_DIR=.uv-cache uv run --group dev ruff check llama_index/core/retrievers/fusion_retriever.py tests/retrievers/test_fusion_retriever.pyUV_CACHE_DIR=.uv-cache uv run --group dev ruff format --check llama_index/core/retrievers/fusion_retriever.py tests/retrievers/test_fusion_retriever.py