fix: deepcopy agent configs in AgentWorkflow to prevent shared mutable state#22150
Open
C1-BA-B1-F3 wants to merge 1 commit into
Open
fix: deepcopy agent configs in AgentWorkflow to prevent shared mutable state#22150C1-BA-B1-F3 wants to merge 1 commit into
C1-BA-B1-F3 wants to merge 1 commit into
Conversation
…e state AgentWorkflow.__init__ stored agent configs by reference, so sharing the same BaseTool or agent config across multiple AgentWorkflow instances would cause them to share mutable state. Apply copy.deepcopy() to each agent config before storing. Fixes run-llama#22146 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
dosubot
Bot
added
the
size:XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AgentWorkflow.__init__stores agent configs by reference:This means if the same
BaseToolinstance or agent config is shared across multipleAgentWorkflowinstances, they share mutable state — mutating one workflow's agent affects the other.Fix
Apply
copy.deepcopy()to each agent config before storing:copywas already imported in the file.Test
Added
test_agents_stored_by_deepcopywhich creates twoAgentWorkflowinstances from the same agent, mutates one, and verifies the other is unaffected.Fixes #22146
🤖 Generated with Claude Code