Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions llama-index-core/llama_index/core/vector_stores/utils.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import json
from typing import Any, Dict, Optional, Tuple, Callable, Mapping, cast
from typing import Any, Dict, Optional, Tuple, Callable, Mapping

from llama_index.core.schema import (
BaseNode,
Expand Down Expand Up @@ -107,7 +107,7 @@ def build_metadata_filter_fn(
if not filter_list or not metadata_filters:
return lambda _: True

filter_condition = cast(MetadataFilters, metadata_filters.condition)
filter_condition = metadata_filters.condition or FilterCondition.AND

def filter_fn(node_id: str) -> bool:
def _process_filter_match(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,21 @@ def test_and_condition_matches_expected_nodes() -> None:
assert fn("n3")


def test_none_condition_defaults_to_and() -> None:
filters = MetadataFilters(
filters=[
MetadataFilter(key="rank", operator=FilterOperator.NE, value="a"),
MetadataFilter(key="weight", operator=FilterOperator.GTE, value=2.0),
],
condition=None,
)
fn = build_metadata_filter_fn(_METADATA_BY_ID.__getitem__, filters)

assert not fn("n1")
assert fn("n2")
assert fn("n3")


def test_or_condition_matches_expected_nodes() -> None:
filters = MetadataFilters(
filters=[
Expand Down