Isolate shared tools between workflow agents#22165
Open
Kevin-Li-2025 wants to merge 1 commit into
Open
Conversation
dosubot
Bot
added
the
size:S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BaseToolinstances when assigning them to workflow agents so the same tool object is not shared across agents by referencemetadata,partial_params) without deep-copying heavy callable/retriever/client resourcesFunctionToolFixes #22146.
Tests
uv run --group dev pytest tests/agent/workflow/test_multi_agent_workflow.py::test_agents_isolate_shared_tool_instances tests/agent/workflow/test_multi_agent_workflow.py::test_basic_workflow tests/agent/workflow/test_multi_agent_workflow.py::test_workflow_requires_root_agent -quv run --group dev pytest tests/agent/workflow/test_multi_agent_workflow.py -quv run --group dev ruff check llama_index/core/agent/workflow/base_agent.py tests/agent/workflow/test_multi_agent_workflow.py