fix(core): use word tokenization for stopword removal in SemanticDoubleMergingSplitterNodeParser#22167
Open
rautaditya2606 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix stopword removal in
SemanticDoubleMergingSplitterNodeParser.The internal
_clean_text_advancedmethod was using the sentence-levelpunkt_tokenizer.tokenizeon punctuation-free text. This caused the entire string to be treated as a single token, rendering the stopword filter ineffective. This PR changes the tokenizer to usere.findall(r"\w+", text)to correctly extract word-level tokens, matching existing word-tokenization conventions in the repository.Fixes #22166
New Package?
Did I fill in the
tool.llamahubsection in thepyproject.tomland provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)llama-index-core)Type of Change
How Has This Been Tested?
Validated locally by running:
Result:
4 passed, 6 skipped.Suggested Checklist
uv run ruff checkanduv run black --check