fix(qdrant): aquery() drops falsy shard_identifier values (e.g. 0)#22169
Open
aloktripathi1 wants to merge 1 commit into
Open
fix(qdrant): aquery() drops falsy shard_identifier values (e.g. 0)#22169aloktripathi1 wants to merge 1 commit into
aloktripathi1 wants to merge 1 commit into
Conversation
aquery() used `if shard_identifier` (truthiness check) instead of `if shard_identifier is not None`. Every other method in this file -- query(), add(), delete(), adelete(), get_nodes(), etc. (9/9 occurrences) -- correctly uses the `is not None` check. This means a valid shard_identifier=0 was silently treated as 'no shard identifier provided' in the async path only, causing the query to run against the wrong (or no) shard partition. 1-line fix, plus a regression test that mocks _generate_shard_key_selector to confirm it's called with 0 specifically (not skipped).
dosubot
Bot
added
the
size:XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aquery() uses
if shard_identifier(truthiness check) instead ofif shard_identifier is not None. Every other method in this file,including query(), add(), delete(), adelete(), get_nodes(), etc. (9/9
occurrences), correctly uses the
is not Nonecheck.This means a valid shard_identifier=0 is silently treated as "no shard
identifier provided" in the async path only, causing the query to run
against the wrong (or no) shard partition.
1-line fix, plus a regression test that mocks _generate_shard_key_selector
to confirm it's called with 0 specifically, not skipped, not coerced to
the default-shard path.