Fix tool schema generation for variadic parameters#22170
Open
fengjikui wants to merge 1 commit into
Open
Conversation
Contributor
|
hi @fengjikui issue author here, please see #22135 it already has the fix :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #22134.
create_schema_from_functionpreviously treated variadic*argsand**kwargsas normal tool parameters. For functions such as:this exposed a phantom
kwargsproperty in the generated JSON schema and marked it as required, which can make strict tool/function-calling providers reject the schema.Changes
inspect.Parameter.VAR_POSITIONALandinspect.Parameter.VAR_KEYWORDwhen building tool schemas.*argsand**kwargs, asserting only regular parameters are exposed.Validation
tests/tools/test_utils.py::test_create_schema_from_function_ignores_variadic_parametersfailed becauseargsandkwargswere present in schema properties.uv run --directory llama-index-core pytest tests/tools/test_utils.py -quv run --directory llama-index-core pytest tests/tools/test_utils.py tests/tools/test_base.py -quv run ruff format --check llama-index-core/llama_index/core/tools/utils.py llama-index-core/tests/tools/test_utils.pyuv run ruff check llama-index-core/llama_index/core/tools/utils.py llama-index-core/tests/tools/test_utils.py